build(CMake): Fix msvc x86/arm64 detection #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurningEnlightenment
force-pushed
the
dev/402_msvc_x86_detection
branch
from
c5019dc to
7842314
Compare
|
@leochou0729 do you have time to test whether this branch fixes the errors you were seeing? |
|
FTR: I've tested the changes by cross-compiling from amd64 to x86 and arm64. |
|
Thanks for doing so much work to support this build. I feel bad about how little I understand it 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor architecture detection logic to allow user overrides via
-DBLAKE3_SIMD_TYPE=xxx.Add special cases for MSVC architecture detection.
CMAKE_SYSTEM_PLATFORMis derived incorrectly outside of user supplied toolchain files[1][2].Furthermore I went ahead and added convenience
CMakePresetsfor MSVC.Fixes #402